Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding lib tests #48

Merged
merged 2 commits into from
Jan 22, 2024
Merged

adding lib tests #48

merged 2 commits into from
Jan 22, 2024

Conversation

vandjelk
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Grouped run commands per module
  • Added test run for KCP module
  • Added build and test step for LIB module
  • Fixed LIB tests

Related issue(s)

@vandjelk vandjelk self-assigned this Jan 18, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2024
@vandjelk vandjelk requested a review from abalaie January 18, 2024 16:11
@vandjelk vandjelk changed the title adding lib tests WIP adding lib tests Jan 18, 2024
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2024
@vandjelk vandjelk marked this pull request as draft January 18, 2024 16:14
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 18, 2024
@vandjelk vandjelk marked this pull request as ready for review January 18, 2024 16:40
tmilos77
tmilos77 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@tmilos77 tmilos77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tmilos77 tmilos77 marked this pull request as draft January 19, 2024 08:03
@vandjelk vandjelk marked this pull request as ready for review January 22, 2024 08:57
@vandjelk vandjelk changed the title WIP adding lib tests adding lib tests Jan 22, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2024
@kyma-bot kyma-bot merged commit c5c75b6 into kyma-project:main Jan 22, 2024
4 checks passed
@vandjelk vandjelk deleted the pr-checks-lib branch January 24, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalaie abalaie Awaiting requested review from abalaie

@tmilos77 tmilos77 Awaiting requested review from tmilos77

Assignees

@vandjelk vandjelk

@tmilos77 tmilos77

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vandjelk @tmilos77 @kyma-bot