Update dependencies for first release of the Compass Manager #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Disper
reviewed
Dec 1, 2023
| @@ -6,8 +6,8 @@ import ( | |||
|
|
|||
| "github.com/kyma-project/compass-manager/api/v1beta1" | |||
| kyma "github.com/kyma-project/lifecycle-manager/api/v1beta2" | |||
| . "github.com/onsi/ginkgo/v2" | |||
| . "github.com/onsi/gomega" | |||
| . "github.com/onsi/ginkgo/v2" //nolint:revive | |||
There was a problem hiding this comment.
I don't understand what could be wrong with this line. Could you elaborate why linter check was failing here and it had to be ignored?
There was a problem hiding this comment.
It was failing because dot import. In most cases (e.g main files) that is bad practice to use this kind of import. But in Go test, if the programmer knows how dot imports work that could be allowed.
In our case, we can remove . and replace it with any name we want. But after that, we need to add that name before any function call exported from that package (e.g Describe(), It(), By(), Expect() ). Such a way will make the main loops of the program less readable and transparent. So that is why I chose that approach.
Disper
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request: