Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace satori go uuid library in api-controller #2883

Closed
piotrmsc opened this issue Feb 27, 2019 · 0 comments
Closed

Replace satori go uuid library in api-controller #2883

piotrmsc opened this issue Feb 27, 2019 · 0 comments
Assignees
Labels
area/service-mesh Issues or PRs related to service-mesh priority/critical Priority indication

Comments

@piotrmsc
Copy link

piotrmsc commented Feb 27, 2019

Description
As a part of code scanning, tool reported usage of https://github.com/satori/go.uuid with high vulnerability of insecure randomness see here
We have to change it to https://github.com/gofrs/uuid which is a new version of old go uuid with fixed problem. Additionally, satori lib is deprecated see here

We use it here

Expected result
We are using gofrs uuid library instead of satori go.uuid

Actual result
satori go.uuid is used.

Steps to reproduce

Troubleshooting

@piotrmsc piotrmsc added the area/service-mesh Issues or PRs related to service-mesh label Feb 27, 2019
@piotrmsc piotrmsc added this to the Backlog_Goat milestone Feb 27, 2019
@ghost ghost added the priority/critical Priority indication label Feb 28, 2019
@piotrmsc piotrmsc modified the milestones: Backlog_Goat, Sprint_Goat_8 Mar 11, 2019
@Demonsthere Demonsthere self-assigned this Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-mesh Issues or PRs related to service-mesh priority/critical Priority indication
Projects
None yet
Development

No branches or pull requests

2 participants