Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unpack from kytos/of_core/utils.py #285

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Remove unpack from kytos/of_core/utils.py #285

merged 1 commit into from
Sep 18, 2017

Conversation

macartur
Copy link
Contributor

@macartur macartur commented Sep 12, 2017 •
edited
Loading

This change is necessary to run kytos/of_core with the PR kytos/python-openflow#444.

This change will affect only kytos/of_core. When a new packet is received this packet will be unpacked using the method unpack from python-openflow.

diraol
diraol reviewed Sep 12, 2017
View reviewed changes
Copy link
Contributor

@diraol diraol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macartur why this is being removed from here?
Does it impact any other NApp?
Please, add some description/comments on the PR or on the commit to add some context on why this change is being made.

@beraldoleal beraldoleal merged commit 18db22b into kytos:master Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diraol diraol diraol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macartur @diraol @beraldoleal