From 9e28f9a6813b96fa1c33afbfc6a22d70f9f57203 Mon Sep 17 00:00:00 2001 From: Dombi Attila <83396+dombesz@users.noreply.github.com> Date: Fri, 17 Nov 2023 17:14:11 +0200 Subject: [PATCH 1/8] [#50782] "Edit meeting dateils" tooltip visible when meeting details modal is cancelled https://community.openproject.org/work_packages/50782 --- .../openproject/_primer-adjustments.sass | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/frontend/src/global_styles/openproject/_primer-adjustments.sass b/frontend/src/global_styles/openproject/_primer-adjustments.sass index 292a3028aa40..4ec2d1d32626 100644 --- a/frontend/src/global_styles/openproject/_primer-adjustments.sass +++ b/frontend/src/global_styles/openproject/_primer-adjustments.sass @@ -47,3 +47,14 @@ action-menu ul.tabnav-tabs margin-left: 0 + +// This fixes the following bug: +// - https://github.com/primer/view_components/issues/2065 +// - https://community.openproject.org/wp/50782 +// If an icon button triggers a dropdown or dialog, the focus moves to the dropdown/dialog. +// When we close the dropdown/dialog, the focus moves back to the button and it also triggers +// displaying the label tooltip. The tooltip also gets stuck open. +// The solution is to hide the tooltip if the focus was not triggered via a mouse click (:hover) +// or if it wasn't triggered by the keyboard (:focus-visible). +button:focus:not(:focus-visible):not(:hover) + tool-tip + visibility: hidden From f4e477622b06030ac575cd1fd2bb5b21220c7405 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20G=C3=BCnther?= Date: Sun, 19 Nov 2023 21:19:44 +0100 Subject: [PATCH 2/8] Make structured meeting the default --- .../meeting/app/views/meetings/_form.html.erb | 110 +++++++++--------- .../spec/features/meetings_copy_spec.rb | 2 + .../spec/features/meetings_new_spec.rb | 7 ++ 3 files changed, 65 insertions(+), 54 deletions(-) diff --git a/modules/meeting/app/views/meetings/_form.html.erb b/modules/meeting/app/views/meetings/_form.html.erb index ff354c53445c..26cac65acb06 100644 --- a/modules/meeting/app/views/meetings/_form.html.erb +++ b/modules/meeting/app/views/meetings/_form.html.erb @@ -35,51 +35,53 @@ See COPYRIGHT and LICENSE files for more details. <%= f.text_field :title, :required => true, :size => 60, container_class: '-wide' %> -
- -
-
-