From 6be9db3c3aec1e434669e9cf0e94f85397197b1b Mon Sep 17 00:00:00 2001
From: Oleg Orlov <mail@orlovoleg.com>
Date: Thu, 9 Mar 2017 12:16:31 +0300
Subject: [PATCH] Delete reactSSR middleware

---
 packages/magma-server/middleware/index.js     |   2 -
 .../magma-server/middleware/offlinePage.js    |   4 +-
 .../middleware/reactSSR/ServerHTML.js         | 132 ------------------
 .../reactSSR/getClientBundleEntryAssets.js    |  54 -------
 .../magma-server/middleware/reactSSR/index.js |  84 -----------
 packages/magma-server/package.json            |  16 +--
 6 files changed, 4 insertions(+), 288 deletions(-)
 delete mode 100644 packages/magma-server/middleware/reactSSR/ServerHTML.js
 delete mode 100644 packages/magma-server/middleware/reactSSR/getClientBundleEntryAssets.js
 delete mode 100644 packages/magma-server/middleware/reactSSR/index.js

diff --git a/packages/magma-server/middleware/index.js b/packages/magma-server/middleware/index.js
index 5cf1aa9..0ede27b 100644
--- a/packages/magma-server/middleware/index.js
+++ b/packages/magma-server/middleware/index.js
@@ -1,4 +1,3 @@
-import createReactSSR from './reactSSR'
 import security from './security'
 import clientBundle from './clientBundle'
 import serviceWorker from './serviceWorker'
@@ -6,7 +5,6 @@ import offlinePage from './offlinePage'
 import errorHandlers from './errorHandlers'
 
 export default {
-  createReactSSR,
   security,
   clientBundle,
   serviceWorker,
diff --git a/packages/magma-server/middleware/offlinePage.js b/packages/magma-server/middleware/offlinePage.js
index 3437abd..28d2dee 100644
--- a/packages/magma-server/middleware/offlinePage.js
+++ b/packages/magma-server/middleware/offlinePage.js
@@ -37,9 +37,9 @@ export default function offlinePageMiddleware(req, res, next) {
       const offlinePageWithNonce = data.replace(
         'OFFLINE_PAGE_NONCE_PLACEHOLDER',
         nonce,
-      );
+      )
       // Send back the page as the response
-      res.send(offlinePageWithNonce);
+      res.send(offlinePageWithNonce)
     },
   )
 }
diff --git a/packages/magma-server/middleware/reactSSR/ServerHTML.js b/packages/magma-server/middleware/reactSSR/ServerHTML.js
deleted file mode 100644
index 5e0287d..0000000
--- a/packages/magma-server/middleware/reactSSR/ServerHTML.js
+++ /dev/null
@@ -1,132 +0,0 @@
-/**
- * This module is responsible for generating the HTML page response for
- * the react application middleware.
- */
-
-/* eslint-disable react/no-danger */
-/* eslint-disable react/no-array-index-key */
-
-import React, { Children, PropTypes } from 'react'
-import serialize from 'serialize-javascript'
-import config from '@lab009/magma-config'
-import ClientConfig from '@lab009/magma-config/ClientConfig'
-import ifElse from '@lab009/magma-utils/logic/ifElse'
-import removeNil from '@lab009/magma-utils/arrays/removeNil'
-
-import getClientBundleEntryAssets from './getClientBundleEntryAssets'
-
-function KeyedComponent({ children }) {
-  return Children.only(children)
-}
-
-// Resolve the assets (js/css) for the client bundle's entry chunk.
-const clientEntryAssets = getClientBundleEntryAssets()
-
-function stylesheetTag(stylesheetFilePath) {
-  return (
-    <link
-      href={stylesheetFilePath}
-      media="screen, projection"
-      rel="stylesheet"
-      type="text/css"
-    />
-  )
-}
-
-function scriptTag(jsFilePath) {
-  return <script type="text/javascript" src={jsFilePath} />
-}
-
-function ServerHTML(props) {
-  const {
-    asyncComponents,
-    helmet,
-    nonce,
-    reactAppString,
-    HTML,
-  } = props
-
-  // Creates an inline script definition that is protected by the nonce.
-  const inlineScript = body => (
-    <script
-      nonce={nonce}
-      type="text/javascript"
-      dangerouslySetInnerHTML={{ __html: body }}
-    />
-  )
-
-  const headerElements = removeNil([
-    ...ifElse(helmet)(() => helmet.meta.toComponent(), []),
-    ...ifElse(helmet)(() => helmet.link.toComponent(), []),
-    ifElse(clientEntryAssets && clientEntryAssets.css)(
-      () => stylesheetTag(clientEntryAssets.css),
-    ),
-    ...ifElse(helmet)(() => helmet.style.toComponent(), []),
-  ])
-
-  const bodyElements = removeNil([
-    // Binds the client configuration object to the window object so
-    // that we can safely expose some configuration values to the
-    // client bundle that gets executed in the browser.
-    <ClientConfig nonce={nonce} />,
-    // Bind our async components state so the client knows which ones
-    // to initialise so that the checksum matches the server response.
-    ifElse(asyncComponents)(
-      () => inlineScript(
-        `window.${asyncComponents.STATE_IDENTIFIER}=${serialize(asyncComponents.state)};`,
-      ),
-    ),
-    // Enable the polyfill io script?
-    // This can't be configured within a react-helmet component as we
-    // may need the polyfill's before our client JS gets parsed.
-    ifElse(config('polyfillIO.enabled'))(
-      () => scriptTag(config('polyfillIO.url')),
-    ),
-    // When we are in development mode our development server will
-    // generate a vendor DLL in order to dramatically reduce our
-    // compilation times.  Therefore we need to inject the path to the
-    // vendor dll bundle below.
-    ifElse(process.env.BUILD_FLAG_IS_DEV && config('bundles.client.devVendorDLL.enabled'))(
-      () => scriptTag(
-        `${config('bundles.client.webPath')}${config('bundles.client.devVendorDLL.name')}.js?t=${Date.now()}`,
-      ),
-    ),
-    ifElse(clientEntryAssets && clientEntryAssets.js)(
-      () => scriptTag(clientEntryAssets.js),
-    ),
-    ...ifElse(helmet)(
-      () => helmet.script.toComponent(),
-      [],
-    ),
-  ])
-
-  return (
-    <HTML
-      title={config('htmlPage.defaultTitle')}
-      description={config('htmlPage.description')}
-      appBodyString={reactAppString}
-      headerElements={
-        headerElements.map((x, idx) => <KeyedComponent key={idx}>{x}</KeyedComponent>)
-      }
-      bodyElements={
-        bodyElements.map((x, idx) => <KeyedComponent key={idx}>{x}</KeyedComponent>)
-      }
-    />
-  )
-}
-
-ServerHTML.propTypes = {
-  asyncComponents: PropTypes.shape({
-    state: PropTypes.object.isRequired,
-    STATE_IDENTIFIER: PropTypes.string.isRequired,
-  }),
-  // eslint-disable-next-line react/forbid-prop-types
-  helmet: PropTypes.object,
-  nonce: PropTypes.string,
-  reactAppString: PropTypes.string,
-  HTML: PropTypes.element,
-};
-
-// EXPORT
-
-export default ServerHTML
diff --git a/packages/magma-server/middleware/reactSSR/getClientBundleEntryAssets.js b/packages/magma-server/middleware/reactSSR/getClientBundleEntryAssets.js
deleted file mode 100644
index 37e731e..0000000
--- a/packages/magma-server/middleware/reactSSR/getClientBundleEntryAssets.js
+++ /dev/null
@@ -1,54 +0,0 @@
-/**
- * This file resolves the entry assets available from our client bundle.
- */
-
-import fs from 'fs'
-import { resolve as pathResolve } from 'path'
-import appRootDir from 'app-root-dir'
-import config from '@lab009/magma-config'
-
-let resultCache
-
-/**
- * Retrieves the js/css for the named chunks that belong to our client bundle.
- *
- * Note: the order of the chunk names is important. The same ordering will be
- * used when rendering the scripts.
- *
- * This is useful to us for a couple of reasons:
- *   - It allows us to target the assets for a specific chunk, thereby only
- *     loading the assets we know we will need for a specific request.
- *   - The assets are hashed, and therefore they can't be "manually" added
- *     to the render logic.  Having this method allows us to easily fetch
- *     the respective assets simply by using a chunk name. :)
- */
-
-export default function getClientBundleEntryAssets() {
-  // Return the assets json cache if it exists.
-  // In development mode we always read the assets json file from disk to avoid
-  // any cases where an older version gets cached.
-  if (!process.env.BUILD_FLAG_IS_DEV && resultCache) {
-    return resultCache
-  }
-
-  const assetsFilePath = pathResolve(
-    appRootDir.get(),
-    config('bundles.client.outputPath'),
-    `./${config('bundleAssetsFileName')}`,
-  )
-
-  if (!fs.existsSync(assetsFilePath)) {
-    throw new Error(
-      `We could not find the "${assetsFilePath}" file, which contains a list of the assets of the client bundle.  Please ensure that the client bundle has been built.`,
-    )
-  }
-
-  const readAssetsJSONFile = () => JSON.parse(fs.readFileSync(assetsFilePath, 'utf8'))
-  const assetsJSONCache = readAssetsJSONFile()
-  if (typeof assetsJSONCache.index === 'undefined') {
-    throw new Error('No asset data found for expected "index" entry chunk of client bundle.')
-  }
-  resultCache = assetsJSONCache.index
-
-  return resultCache
-}
diff --git a/packages/magma-server/middleware/reactSSR/index.js b/packages/magma-server/middleware/reactSSR/index.js
deleted file mode 100644
index e1a3c4c..0000000
--- a/packages/magma-server/middleware/reactSSR/index.js
+++ /dev/null
@@ -1,84 +0,0 @@
-
-import React from 'react'
-import Helmet from 'react-helmet'
-import { renderToString, renderToStaticMarkup } from 'react-dom/server'
-import { StaticRouter } from 'react-router-dom'
-import { withAsyncComponents } from '@lab009/splitter'
-import config from '@lab009/magma-config'
-
-import ServerHTML from './ServerHTML'
-
-/**
- * React application middleware, supports server side rendering.
- */
-
-export default function createReactSSRMiddleware(App, HTML) {
-  return (request, response) => {
-    // Ensure a nonce has been provided to us.
-    // See the server/middleware/security.js for more info.
-    if (typeof response.locals.nonce !== 'string') {
-      throw new Error('A "nonce" value has not been attached to the response')
-    }
-    const nonce = response.locals.nonce
-
-    // It's possible to disable SSR, which can be useful in development mode.
-    // In this case traditional client side only rendering will occur.
-    if (config('disableSSR')) {
-      if (process.env.BUILD_FLAG_IS_DEV) {
-        // eslint-disable-next-line no-console
-        console.log('==> Handling react route without SSR')
-      }
-      // SSR is disabled so we will return an "empty" html page and
-      // rely on the client to initialize and render the react application.
-      const html = renderToStaticMarkup(<ServerHTML nonce={nonce} HTML={HTML} />)
-
-      response.status(200).send(html)
-      return
-    }
-
-    // First create a context for <StaticRouter>, which will allow us to
-    // query for the results of the render.
-    const reactRouterContext = {}
-
-    // Declare our React application.
-    const app = (
-      <StaticRouter location={request.url} context={reactRouterContext}>
-        <App />
-      </StaticRouter>
-    )
-
-    // Pass our app into the @lab009/splitter helper so that any async
-    // components are resolved for the render.
-    withAsyncComponents(app).then(async ({ appWithAsyncComponents, state, STATE_IDENTIFIER }) => {
-      // Generate the html response.
-      const html = renderToStaticMarkup(
-        <ServerHTML
-          HTML={HTML}
-          reactAppString={renderToString(appWithAsyncComponents)}
-          nonce={nonce}
-          helmet={Helmet.rewind()}
-          asyncComponents={{ state, STATE_IDENTIFIER }}
-        />,
-      )
-
-      // Check if the router context contains a redirect, if so we need to set
-      // the specific status and redirect header and end the response.
-      if (reactRouterContext.url) {
-        response.status(302).setHeader('Location', reactRouterContext.url)
-        response.end()
-        return
-      }
-
-      response
-        .status(
-        reactRouterContext.missed
-          // If the renderResult contains a "missed" match then we set a 404 code.
-          // Our App component will handle the rendering of an Error404 view.
-          ? 404
-          // Otherwise everything is all good and we send a 200 OK status.
-          : 200,
-      )
-        .send(`<!DOCTYPE html>${html}`)
-    })
-  }
-}
diff --git a/packages/magma-server/package.json b/packages/magma-server/package.json
index 88e4843..fa5c868 100644
--- a/packages/magma-server/package.json
+++ b/packages/magma-server/package.json
@@ -15,33 +15,21 @@
   },
   "license": "MIT",
   "peerDependencies": {
-    "@lab009/splitter": "^1.0.0",
-    "express": "^4.15.0",
-    "react": "^15.0.0",
-    "react-dom": "^15.0.0",
-    "react-helmet": "^4.0.0",
-    "react-router-dom": "^4.0.0"
+    "express": "^4.15.0"
   },
   "dependencies": {
     "@lab009/magma-config": "1.0.0",
-    "@lab009/magma-utils": "1.0.0",
     "app-root-dir": "1.0.2",
     "helmet": "3.4.1",
     "hpp": "0.2.1",
-    "serialize-javascript": "1.3.0",
     "uuid": "3.0.1"
   },
   "devDependencies": {
     "@lab009/eslint-config-magma": "3.0.4",
-    "@lab009/splitter": "1.0.0",
     "eslint": "3.17.1",
     "eslint-plugin-import": "2.2.0",
     "eslint-plugin-jsx-a11y": "4.0.0",
     "eslint-plugin-react": "6.10.0",
-    "express": "4.15.2",
-    "react": "15.4.2",
-    "react-dom": "15.4.2",
-    "react-helmet": "4.0.0",
-    "react-router-dom": "4.x"
+    "express": "4.15.2"
   }
 }