Use table driven subtests for proxy/rewrite tests

Author: lammel

middleware/proxy_test.go

@@ -247,11 +247,14 @@ func TestProxyRewriteRegex(t *testing.T) {
 		{"/y/foo/bar", http.StatusOK, "/v5/bar/foo"},
 	}
 
+
 	for _, tc := range testCases {
-		req.URL, _ = url.Parse(tc.requestPath)
-		rec = httptest.NewRecorder()
-		e.ServeHTTP(rec, req)
-		assert.Equal(t, tc.expectPath, req.URL.EscapedPath())
-		assert.Equal(t, tc.statusCode, rec.Code)
+		t.Run(tc.requestPath, func(t *testing.T) {
+			req.URL, _ = url.Parse(tc.requestPath)
+			rec = httptest.NewRecorder()
+			e.ServeHTTP(rec, req)
+			assert.Equal(t, tc.expectPath, req.URL.EscapedPath())
+			assert.Equal(t, tc.statusCode, rec.Code)
+		})
 	}
 }

middleware/rewrite_test.go

@@ -163,10 +163,12 @@ func TestEchoRewriteWithRegexRules(t *testing.T) {
 		{"/y/foo/bar", "/v5/bar/foo"},
 	}
 
-	for _, tc := range testCases {
-		req = httptest.NewRequest(http.MethodGet, tc.requestPath, nil)
-		rec = httptest.NewRecorder()
-		e.ServeHTTP(rec, req)
-		assert.Equal(t, tc.expectPath, req.URL.EscapedPath())
-	}
+		for _, tc := range testCases {
+			t.Run(tc.requestPath, func(t *testing.T) {
+				req = httptest.NewRequest(http.MethodGet, tc.requestPath, nil)
+				rec = httptest.NewRecorder()
+				e.ServeHTTP(rec, req)
+				assert.Equal(t, tc.expectPath, req.URL.EscapedPath())
+			})
+		}
 }