Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1423: Use case sensitive only for bind query params #1491

Closed
wants to merge 1 commit into from
Closed

Fix #1423: Use case sensitive only for bind query params #1491

wants to merge 1 commit into from

Conversation

alissonbrunosa
Copy link

@alissonbrunosa alissonbrunosa commented Jan 27, 2020

The problem was being caused because method bindData tries to get the value when the parameter name does not match with the tag name.

As this logic seems to make sense only for query parameters, I've added an extra condition to run the case sensitive logic only when the tag is query

Fixes #1423

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #1491 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1491   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files          27       27           
  Lines        2077     2077           
=======================================
  Hits         1752     1752           
  Misses        212      212           
  Partials      113      113
Impacted Files Coverage Δ
bind.go 85.71% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 712b5e4...e5643d9. Read the comment docs.

@stale
Copy link

stale bot commented Mar 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 28, 2020
@stale stale bot closed this Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binding confusion when params and request body have the same named field
1 participant