From e6d44317355f70e78082501e4a1d5ce5aec492e9 Mon Sep 17 00:00:00 2001 From: zhangzhe <2277100031@qq.com> Date: Mon, 21 Feb 2022 20:42:36 +0800 Subject: [PATCH 1/2] add echo test --- echo_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/echo_test.go b/echo_test.go index f175d765b..5aed4381b 100644 --- a/echo_test.go +++ b/echo_test.go @@ -61,6 +61,9 @@ func TestEcho(t *testing.T) { // Router assert.NotNil(t, e.Router()) + // Routers + assert.NotNil(t, e.Routers()) + // DefaultHTTPErrorHandler e.DefaultHTTPErrorHandler(errors.New("error"), c) assert.Equal(t, http.StatusInternalServerError, rec.Code) From c58b7e6f99aff8d2d2f2ec6772aa532b443fb095 Mon Sep 17 00:00:00 2001 From: zhangzhe <2277100031@qq.com> Date: Wed, 23 Feb 2022 15:09:05 +0800 Subject: [PATCH 2/2] remove unused notFoundHandler in echo --- echo.go | 1 - echo_test.go | 3 --- 2 files changed, 4 deletions(-) diff --git a/echo.go b/echo.go index 2e63cc6b1..88a732ee7 100644 --- a/echo.go +++ b/echo.go @@ -75,7 +75,6 @@ type ( maxParam *int router *Router routers map[string]*Router - notFoundHandler HandlerFunc pool sync.Pool Server *http.Server TLSServer *http.Server diff --git a/echo_test.go b/echo_test.go index 5aed4381b..f175d765b 100644 --- a/echo_test.go +++ b/echo_test.go @@ -61,9 +61,6 @@ func TestEcho(t *testing.T) { // Router assert.NotNil(t, e.Router()) - // Routers - assert.NotNil(t, e.Routers()) - // DefaultHTTPErrorHandler e.DefaultHTTPErrorHandler(errors.New("error"), c) assert.Equal(t, http.StatusInternalServerError, rec.Code)