You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes swagger definitions for the geography API.
Actually, this could/should be part of the OMF spec repo, but as the version in mds core is not the most current one and e. g. there cannot be a commit to the 1.0-branch of the spec in the past, I'll focus on adding it here
👌 Includes (WIP state):
/geographies
schema definitions
operation definitions
examples
Mock service
Remark: In order to make this PR merge-able earlier, I removed the policy-related API from this PR. I'll create another one for that purpose
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@mrsimpson this looks great! I think even though this isn't using any of the schema generation or anything, it's still useful from a documentation perspective.
@avatarneil I reduced this PR to /geography. I got sidetracked by other stuff and will not be able to complete the policy part in the next days.
Therefore, feel free to merge this not holistic but imho consistent PR
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mrsimpson
changed the title
📚 Purpose
This PR includes swagger definitions for the geography API.
Actually, this could/should be part of the OMF spec repo, but as the version in mds core is not the most current one and e. g. there cannot be a commit to the 1.0-branch of the spec in the past, I'll focus on adding it here
👌 Includes (WIP state):
/geographiesRemark: In order to make this PR merge-able earlier, I removed the policy-related API from this PR. I'll create another one for that purpose