Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test cases for flamegraph #39

Merged
merged 3 commits into from
Oct 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions flameshow/render/flamegraph.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,6 @@ def render_line(self, y: int) -> Strip:
for frame in line:
frame_maps = self.frame_maps.get(frame._id)
if not frame_maps:
logger.debug(
"frame %s not found in frame_map, not render this.", frame
)
continue
frame_map = frame_maps[self.sample_index]
my_width = frame_map.width
Expand Down Expand Up @@ -236,10 +233,6 @@ def render_line(self, y: int) -> Strip:
strip = Strip(segments)
return strip

@property
def sample_unit(self):
return self.profile.sample_types[self.sample_index].sample_unit

def action_zoom_in(self):
logger.info("Zoom in!")
self.focused_stack_id = self.view_frame._id
Expand All @@ -259,9 +252,6 @@ def action_move_down(self):

# go to the biggest value
new_view_info_frame = self._get_biggest_exist_child(children)
if not new_view_info_frame:
logger.warn("Got no children displayed!")
return
self.post_message(self.ViewFrameChanged(new_view_info_frame))

def _get_biggest_exist_child(self, stacks):
Expand Down
Loading