Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor biguint_to_felt and bigint_to_felt functions #1495

Closed
pefontana opened this issue Nov 24, 2023 · 0 comments · Fixed by #1562
Closed

Refactor biguint_to_felt and bigint_to_felt functions #1495

pefontana opened this issue Nov 24, 2023 · 0 comments · Fixed by #1562
Assignees
@fmoletta

Comments

@pefontana
Copy link
Collaborator

pefontana commented Nov 24, 2023 •
edited
Loading

We should delete the functions felt_to_biguint, felt_to_bigint, biguint_to_felt and bigint_to_felt

cairo-vm/vm/src/utils.rs

Line 67 in 55eaaa7

pub fn biguint_to_felt(biguint: &BigUint) -> Result<crate::Felt252, MathError> {

And use the BigUint and BigInts conversion to felt, provided by the starknet-types-core crate
@pefontana pefontana moved this to Backlog in Starknet Nov 24, 2023
@pefontana pefontana moved this from Backlog to Todo in Starknet Nov 27, 2023
@fmoletta fmoletta self-assigned this Jan 12, 2024
@fmoletta fmoletta mentioned this issue Jan 12, 2024
Merged
@fmoletta fmoletta moved this from Todo to In Review in Starknet Jan 18, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Starknet Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmoletta fmoletta

Labels
None yet
Projects
Starknet
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unecessary conversion functions between Felt & BigUint/BigInt lambdaclass/cairo-vm
2 participants
@pefontana @fmoletta