Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Wasm32 support (#828)" #891

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Revert "Wasm32 support (#828)" #891

merged 1 commit into from
Mar 10, 2023

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Mar 10, 2023

This reverts commit c326ba8.

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #891 (4cf5973) into main (17f467c) will increase coverage by 0.05%.
The diff coverage is 90.38%.

@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
+ Coverage   97.41%   97.46%   +0.05%     
==========================================
  Files          69       69              
  Lines       29141    29070      -71     
==========================================
- Hits        28387    28333      -54     
+ Misses        754      737      -17     
Impacted Files Coverage Δ
...t_processor/builtin_hint_processor/blake2s_hash.rs 100.00% <ø> (ø)
..._processor/builtin_hint_processor/blake2s_utils.rs 99.74% <ø> (ø)
...int_processor/builtin_hint_processor_definition.rs 98.69% <ø> (ø)
...uiltin_hint_processor/cairo_keccak/keccak_hints.rs 93.91% <ø> (ø)
...rocessor/builtin_hint_processor/dict_hint_utils.rs 99.23% <ø> (-0.01%) ⬇️
...t_processor/builtin_hint_processor/dict_manager.rs 96.73% <ø> (ø)
...int_processor/builtin_hint_processor/hint_utils.rs 94.59% <ø> (ø)
...t_processor/builtin_hint_processor/keccak_utils.rs 100.00% <ø> (ø)
...int_processor/builtin_hint_processor/math_utils.rs 97.95% <ø> (+<0.01%) ⬆️
...cessor/builtin_hint_processor/memcpy_hint_utils.rs 100.00% <ø> (ø)
... and 58 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jrigada Jrigada merged commit 23d941f into main Mar 10, 2023
@Jrigada Jrigada deleted the revert-no-std branch March 10, 2023 13:38
Oppen added a commit that referenced this pull request Mar 10, 2023
Oppen added a commit that referenced this pull request Mar 10, 2023
Oppen added a commit that referenced this pull request Mar 13, 2023
Oppen added a commit that referenced this pull request Mar 14, 2023
* Revert "Revert "Wasm32 support (#828)" (#891)"

This reverts commit 23d941f.

* Some optimizations

* Fix mimalloc build for cairo-vm-cli

* Use 3MiB for execution trace buffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants