Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Absorb DjangoORM.create() in DjangoORM.__init__() #707

Merged
merged 17 commits into from
Jun 3, 2023
Merged

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Jun 3, 2023

@falexwolf falexwolf changed the title ♻️ Absorb create in __init__ ♻️ Absorb ORM.create() in ORM.__init__() Jun 3, 2023
@falexwolf falexwolf changed the title ♻️ Absorb ORM.create() in ORM.__init__() ♻️ Absorb DjangoORM.create() in DjangoORM.__init__() Jun 3, 2023
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #707 (fa61751) into main (9327542) will decrease coverage by 2.71%.
The diff coverage is 65.68%.

❗ Current head fa61751 differs from pull request most recent head 8f0ff93. Consider uploading reports for the commit 8f0ff93 to get more accurate results

@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
- Coverage   72.63%   69.93%   -2.71%     
==========================================
  Files          48       48              
  Lines        1959     2032      +73     
==========================================
- Hits         1423     1421       -2     
- Misses        536      611      +75     
Impacted Files Coverage Δ
lamindb/_check_versions.py 33.33% <0.00%> (-16.67%) ⬇️
lamindb/_nb.py 43.24% <0.00%> (-37.84%) ⬇️
lamindb/_context.py 60.00% <54.05%> (+1.66%) ⬆️
lamindb/_amend_file.py 82.60% <61.53%> (-6.46%) ⬇️
lamindb/dev/db/_core.py 84.61% <66.66%> (-10.63%) ⬇️
lamindb/dev/db/_add.py 82.11% <90.00%> (-4.10%) ⬇️
lamindb/dev/db/_select.py 88.97% <90.00%> (-3.83%) ⬇️
lamindb/__init__.py 100.00% <100.00%> (ø)
lamindb/_amend_folder.py 92.30% <100.00%> (+2.30%) ⬆️
lamindb/_delete.py 72.13% <100.00%> (+2.28%) ⬆️
... and 2 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

@github-actions github-actions bot temporarily deployed to pull request June 3, 2023 18:16 Inactive
@falexwolf falexwolf merged commit d159f38 into main Jun 3, 2023
@falexwolf falexwolf deleted the create branch June 3, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant