Improve message for discarded pure non-Unit values #18723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-18722
branch
from
23594b1
to
b64aa8e
Compare
bishabosha
reviewed
Oct 19, 2023
Yes, it also fixes that issue. I will add it to the tests. |
nicolasstucki
force-pushed
the
fix-18722
branch
3 times, most recently
from
a057274
to
d82a328
Compare
bishabosha
approved these changes
Oct 20, 2023
|
does this still need to be a draft? |
nicolasstucki
force-pushed
the
fix-18722
branch
from
d82a328
to
7451a18
Compare
I added a second commit with some extra cleanups. Now it is ready for review. |
nicolasstucki
commented
Oct 20, 2023
| @@ -1,7 +1,7 @@ | |||
| -- [E129] Potential Issue Warning: tests/neg-macros/annot-suspend-cycle/Macro.scala:7:4 -------------------------------- | |||
| 7 | new Foo | |||
| | ^^^^^^^ | |||
| | A pure expression does nothing in statement position; you may be omitting necessary parentheses | |||
| | A pure expression does nothing in statement position | |||
There was a problem hiding this comment.
This one might not be correct. I will double check it.
There was a problem hiding this comment.
It is correct. Class Foo has a pure constructor.
bishabosha
approved these changes
Oct 20, 2023
The `you may be omitting necessary parentheses` hint in the message was added when we used to get method references that became lambdas in statement positions. Now these are an error and never reach this warning.
nicolasstucki
force-pushed
the
fix-18722
branch
from
5c43c66
to
7f48230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18408
Fixes #18722