Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky VoronoiModelGrid test on mac #1516

Open
mcflugen opened this issue Dec 5, 2022 · 0 comments
Open

Flaky VoronoiModelGrid test on mac #1516

mcflugen opened this issue Dec 5, 2022 · 0 comments

Comments

@mcflugen
Copy link
Member

mcflugen commented Dec 5, 2022

The doctest for the VoronoiModelGrid.save method has become somewhat flaky recently.

The doctest is the following,

>>> from landlab import VoronoiDelaunayGrid
>>> import numpy as np
>>> import os
>>> x = np.random.rand(20)
>>> y = np.random.rand(20)
>>> vmg = VoronoiDelaunayGrid(x,y)
Traceback (most recent call last):
...
ValueError: cannot reindex or align along dimension 'cell' because of conflicting dimension sizes: {20, 21}

Apparently some combination of random x and y coordinates cause the save function to fail.

It may make sense to alter to doctest to use non-random coordinates but then add some unit tests that identify and test the underlying issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant