[Exception Handling] DeepSeek JSONDecodeError #29758
Conversation
dosubot
bot
added
size:M
bug
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
This is a problem with DeepSeek. I don't think we should handle this in langchain-openai (there are many providers who subclass BaseChatOpenAI, it's not tenable to account for these possibilities for all providers).
What do you think about implementing this on ChatDeepSeek-- e.g., overriding _stream and other methods and handling exceptions when you call super()._stream?
|
Aha, thank you @ccurme, I didn't know that it is used by others other than Openai and Deepseek. You are absolutely right about your concern. I will make the suggested changes and revert the BaseChatOpenAI changes. |
…ch for meaningful output" This reverts commit 4bd23d6.
AhmedTammaa
changed the title
|
@ccurme I have made the changes as suggested. However, I need an advice here: Should I raise the error as ValueError as we have it from the parent class or JSONDecodeError? please note I did a small refactor in the function |
| except ValueError as e: | ||
| raise ValueError( |
There was a problem hiding this comment.
Should we catch ValueError, or JSONDecodeError?
In this commit we were catching JSONDecodeError: 4bd23d6
I think we should raise the same error type as is emitted now (e.g., JSONDecodeError, if that's what the client raises).
There was a problem hiding this comment.
Perfect thank you very much. I was very perplexed here. I will update it
|
I handled the exception as JSONDecodeError as this the triggered exception. |
dosubot
bot
added
the
lgtm
For Context please check #29626
The Deepseek is using langchain_openai. The error happens that it show
json decode error.I added a handler for this to give a more sensible error message which is DeepSeek API returned empty/invalid json.
Reproducing the issue is a bit challenging as it is inconsistent, sometimes DeepSeek returns valid data and in other times it returns invalid data which triggers the JSON Decode Error.
This PR is an exception handling, but not an ultimate fix for the issue.