[11.x] Fail url checking when url is invalid (#984) #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fail url checking when url is invalid * Update VerifyRedirectUrl.php Co-authored-by: Taylor Otwell <taylor@laravel.com>
|
@driesvints can you verify this fix is correct? I don't mind getting this into 11.x |
|
Yep looks fine thanks! |
|
Released v11.3.1 with this fix: https://github.com/laravel/cashier-stripe/releases/tag/v11.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to copy a bug fix that was committed to the
12.xbranch into the11.xbranch.See #984
The current version of
laravel/spark-aurelius(11.0) currently requires"laravel/cashier": "^11.0", in which this bug is still present.I am aware that the Laravel Contribution guide specifies that all bug fixes should only be committed in the latest stable branch. However, since the latest stable branch of
laravel/spark-aureliusrequires an older version oflaravel/cashier, I believe that it would be appropriate to perform this patch on the older branch.