[13.x] Refactor receipts with more data from Stripe #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will refactor receipts so it'll pull more data from Stripe directly. There's now more info on the receipts like customer address, tax ids, etc. Also the
description/memo field is added automatically. The vendor details still need to be provided explicitly because Stripe doesn't adds that historical data to the invoice object.There's almost no breaking changes. Things that I can think of are the fact that the customer name (previously the
to:info) is now derived directly from the Stripe customer.vendorandproductparameters are now optional instead of required.Here's a before / after of the receipts:
Closes #952