Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.x] Implement invoice renderer #1304

Merged
merged 5 commits into from
Jan 25, 2022
Merged

[12.x] Implement invoice renderer #1304

merged 5 commits into from
Jan 25, 2022

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Jan 21, 2022

This PR implements a way to use a different renderer for invoices in Cashier. This way, more powerful renderers like Browsershot can be used.

This PR is fully backwards compatible with current code. Additionally it:

  • Adds a new option to set a custom renderer that's resolved from the container
  • Together with some options that can be passed to the renderer
  • Moves all dompdf functionality to its dedicated DompdfInvoiceRenderer class
  • Binds that class to the new InvoiceRenderer contract by default

@taylorotwell I'll need your help with the config option description 😅

@driesvints driesvints changed the title Implement invoice renderer [12.x] Implement invoice renderer Jan 21, 2022
@driesvints driesvints marked this pull request as ready for review January 24, 2022 10:48
@driesvints
Copy link
Member Author

Please note that tests are failing due to rate limiting in Stripe.

@taylorotwell taylorotwell merged commit e0767e6 into 12.x Jan 25, 2022
@taylorotwell taylorotwell deleted the invoice-renderer branch January 25, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants