[9.0] Fixing defaultCard() exception when not Stripe customer
#660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of returning null if the billable model had no stripe Id
driesvints
requested changes
May 2, 2019
driesvints
changed the title
defaultCard() exception when not Stripe customerdefaultCard() exception when not Stripe customer
driesvints
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Laravel Team!
Summary:
This pull request addresses an issue where the
defaultCard()method on the billable trait would throw an exception if the model was not created as a stripe customer.Expected:
Calling the
defaultCard()method will return null if the user has no card on file, even when the billable model is not set up as a Stripe customer.Actual:
An exception is thrown:
Stripe\Error\InvalidRequest: Could not determine which URL to request: Stripe\Customer instance has invalid ID:.Fix:
Checking to make sure that the billable model has a stripe ID before attempting to retrieve the model as a stripe customer, so we are not sending the Stripe PHP library invalid data.