[10.0] Multiple stripe accounts #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to overwrite the default Stripe options on the Billable model. This allows to customize the Stripe secret key amongst else.
There's one concern: since there's no concept of a customer in the
PaymentControllerso there's no way to overwrite the public and secret key there. I've thought about how to solve this but the only way is to pass the customer ID with the url. But that'd be a breaking change and a bit cumbersome to handle. ThePaymentControllercan be easily overwritten though to do any customization here.Closes #751