Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @throws declaration to methods on Billable which can throw Payment exceptions #872

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

ValCanBuild
Copy link
Contributor

In the documentation https://laravel.com/docs/6.x/billing#payments-requiring-additional-confirmation it's stated the the methods charge invoice and invoiceFor on a user can throw IncompletePayment exceptions but the methods documention wasn't marked as such.

This PR just adds those @throws tags to the methods.

@driesvints driesvints merged commit e5670b5 into laravel:10.0 Feb 20, 2020
@driesvints
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants