From 9cf0eb9d3afa25b87675dc6d573f827f6509f749 Mon Sep 17 00:00:00 2001 From: Sjors Ottjes Date: Tue, 23 Mar 2021 16:24:31 +0100 Subject: [PATCH 1/2] make ResponseSequence macroable --- src/Illuminate/Http/Client/ResponseSequence.php | 3 +++ tests/Http/HttpClientTest.php | 11 +++++++++++ 2 files changed, 14 insertions(+) diff --git a/src/Illuminate/Http/Client/ResponseSequence.php b/src/Illuminate/Http/Client/ResponseSequence.php index 66d0ec6bbce4..0fb6fb021dd6 100644 --- a/src/Illuminate/Http/Client/ResponseSequence.php +++ b/src/Illuminate/Http/Client/ResponseSequence.php @@ -2,10 +2,13 @@ namespace Illuminate\Http\Client; +use Illuminate\Support\Traits\Macroable; use OutOfBoundsException; class ResponseSequence { + use Macroable; + /** * The responses in the sequence. * diff --git a/tests/Http/HttpClientTest.php b/tests/Http/HttpClientTest.php index d5be7aefaf25..ce007b429f33 100644 --- a/tests/Http/HttpClientTest.php +++ b/tests/Http/HttpClientTest.php @@ -7,7 +7,9 @@ use Illuminate\Http\Client\Request; use Illuminate\Http\Client\RequestException; use Illuminate\Http\Client\Response; +use Illuminate\Http\Client\ResponseSequence; use Illuminate\Support\Collection; +use Illuminate\Support\Facades\Http; use Illuminate\Support\Str; use OutOfBoundsException; use PHPUnit\Framework\AssertionFailedError; @@ -802,4 +804,13 @@ public function testCanDump() VarDumper::setHandler(null); } + + public function testResponseSequenceIsMacroable() + { + ResponseSequence::macro('customMethod', function () { + return 'yes!'; + }); + + $this->assertSame('yes!', $this->factory->fakeSequence()->customMethod()); + } } From 9ee841cf7724733b7108c26aed6960c9ab83d70b Mon Sep 17 00:00:00 2001 From: Sjors Ottjes Date: Tue, 23 Mar 2021 16:42:52 +0100 Subject: [PATCH 2/2] cs --- tests/Http/HttpClientTest.php | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/Http/HttpClientTest.php b/tests/Http/HttpClientTest.php index ce007b429f33..63e07bfbf7e1 100644 --- a/tests/Http/HttpClientTest.php +++ b/tests/Http/HttpClientTest.php @@ -9,7 +9,6 @@ use Illuminate\Http\Client\Response; use Illuminate\Http\Client\ResponseSequence; use Illuminate\Support\Collection; -use Illuminate\Support\Facades\Http; use Illuminate\Support\Str; use OutOfBoundsException; use PHPUnit\Framework\AssertionFailedError;