Write to stderr and stdout synchronously on Windows (#295)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

Author: timacdonald

agent/build/agent.phar

@@ -1 +1 @@
-7C57EC370DB9656684D0C8325B8D889DDE1D90C286CBD38F9DFA997A96AF1212EA6518E6DE88DA8476F5A7A34FA2D5EBC5BC0914AA7EC73B36FBE53C4ABB3357
+679D81B7198B1960B0FD84EECB611AE03AA656CCB75FBEAC6DA3E4C2E8D5A515C2C6A01D213E8BC5D3227D677BE7CB8D442F576D80A09FA71956E26539550DB6

agent/build/signature.txt

@@ -4,28 +4,29 @@
 
 use React\Stream\WritableResourceStream;
 
+use function fflush;
 use function Nightwatch\fwrite_all;
 
 class OutputWriter
 {
-    private WritableResourceStream $loopStream;
-
     /**
-     * @param  resource  $stream
+     * @param  resource  $syncStream
      */
     public function __construct(
         private Loop $loop,
-        private $stream,
+        private $syncStream,
+        private ?WritableResourceStream $asyncStream,
     ) {
-        $this->loopStream = new WritableResourceStream($stream);
+        //
     }
 
     public function write(string $message): void
     {
-        if ($this->loop->running()) {
-            $this->loopStream->write($message);
+        if ($this->loop->running() && $this->asyncStream !== null) {
+            $this->asyncStream->write($message);
         } else {
-            fwrite_all($this->stream, $message);
+            fwrite_all($this->syncStream, $message);
+            fflush($this->syncStream);
         }
     }
 }

agent/src/OutputWriter.php

@@ -12,6 +12,7 @@
 use React\EventLoop\StreamSelectLoop;
 use React\Socket\ServerInterface;
 use React\Socket\TcpServer;
+use React\Stream\WritableResourceStream;
 
 use function date;
 use function file_get_contents;
@@ -82,8 +83,13 @@
  * Logging helpers...
  */
 
-$stdOut = new OutputWriter($loop, STDOUT);
-$stdErr = new OutputWriter($loop, STDERR);
+[$asyncStdOut, $asyncStdError] = match (PHP_OS_FAMILY) {
+    'Windows' => [null, null],
+    default => [new WritableResourceStream(STDOUT), new WritableResourceStream(STDERR)],
+};
+
+$stdOut = new OutputWriter($loop, syncStream: STDOUT, asyncStream: $asyncStdOut);
+$stdErr = new OutputWriter($loop, syncStream: STDERR, asyncStream: $asyncStdError);
 
 $debug = static function (string $message) use ($verbose, $stdOut): void {
     if ($verbose) {