Merge pull request #318 from mnightingale/skip-empty-updates

[6.0] Skip empty updates

src/Engines/AlgoliaEngine.php

@@ -46,7 +46,7 @@ public function update($models)
             $models->each->pushSoftDeleteMetadata();
         }
 
-        $index->addObjects($models->map(function ($model) {
+        $objects = $models->map(function ($model) {
             $array = array_merge(
                 $model->toSearchableArray(), $model->scoutMetadata()
             );
@@ -56,7 +56,11 @@ public function update($models)
             }
 
             return array_merge(['objectID' => $model->getScoutKey()], $array);
-        })->filter()->values()->all());
+        })->filter()->values()->all();
+
+        if (! empty($objects)) {
+            $index->addObjects($objects);
+        }
     }
 
     /**

tests/AlgoliaEngineTest.php

@@ -7,6 +7,7 @@
 use Laravel\Scout\Engines\AlgoliaEngine;
 use Tests\Fixtures\AlgoliaEngineTestCustomKeyModel;
 use Tests\Fixtures\AlgoliaEngineTestModel;
+use Tests\Fixtures\EmptyTestModel;
 use Illuminate\Database\Eloquent\Collection;
 
 class AlgoliaEngineTest extends AbstractTestCase
@@ -99,4 +100,14 @@ public function test_flush_a_model()
         $engine = new AlgoliaEngine($client);
         $engine->flush(new AlgoliaEngineTestCustomKeyModel());
     }
+
+    public function test_update_empty_searchable_array_does_not_add_objects_to_index()
+    {
+        $client = Mockery::mock('AlgoliaSearch\Client');
+        $client->shouldReceive('initIndex')->with('table')->andReturn($index = Mockery::mock('StdClass'));
+        $index->shouldNotReceive('addObjects');
+
+        $engine = new AlgoliaEngine($client);
+        $engine->update(Collection::make([new EmptyTestModel()]));
+    }
 }

tests/Fixtures/EmptyTestModel.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Tests\Fixtures;
+
+class EmptyTestModel extends TestModel
+{
+    public function toSearchableArray()
+    {
+        return [];
+    }
+}