Mark exceptions as resolved #710
Conversation
|
The button looks slightly too low. It's not vertically aligned with the text on the left. |
|
Is this better?
|
|
Hmm, it looks more aligned but now the top padding on the button appears much less than the bottom padding. Sorry I am picky about these things 😬 |
|
But isn't that exactly the same as the Auth tag? Tried using the built in styling classes. |
|
Do you mean inside the button? Because the padding above the lowercase letters it the same top and bottom. Only the uppercase 'R' and 'l' are closer to the top. So not really sure how it should be aligned otherwise: |
|
Maybe the |
|
@GertjanRoke can you screenshot that? |
|
I saw that Github does the same with there badges. |
|
I can change that, but that would be benifitial for all |
|
@taylorotwell I thought I would make a better screenshot for you by rebuilding what @barryvdh had in his first screenshot. So this one is with
And this one is with
And this is with the current styling:
Hope this makes it easier to decide what the best option is. |
|
I'll just go as-is for now. |
|
Thanks, should I submit a PR to rebuild assets and perhaps tag a new release after that, to prepare for 6.0? |
… are marked as resolved the message isn't clear to the user. For once I thought Laravel Telescope would itself automagically resolve the exception for me since that's what the message suggested (Resolve now). This change is to indicate to users that exceptions aren't resolved by Laravel Telescope but marked as resolved, so they have to go resolve the exception themselves and mark as resolved on Laravel Telescope which is the intention of pull request laravel#710
This allows to mark exceptions as resolved, and show warnings when not resolved.
If an Exception occurs again, it's shown as not-resolved again (because the last entry is shown, which is good).