Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Adds health check command #153

Merged
merged 3 commits into from
Apr 25, 2023
Merged

[2.x] Adds health check command #153

merged 3 commits into from
Apr 25, 2023

Conversation

joedixon
Copy link
Contributor

@joedixon joedixon commented Apr 19, 2023

This PR adds a new hidden command to the Vapor Core which will be used during deployment to determine whether or not an environment being deployed is healthy or not.

Updates to the tests are due to an change to laminas-diactoros

@joedixon joedixon requested a review from nunomaduro April 20, 2023 13:49
@joedixon joedixon marked this pull request as ready for review April 25, 2023 08:47
@joedixon joedixon merged commit 83fe61a into 2.0 Apr 25, 2023
@joedixon joedixon deleted the feat/health-check branch April 25, 2023 08:47
@williamjulianvicary
Copy link

This broke my builds on v2.28 of Vapor Core somehow. Upgrading to the latest release sorted the issue:

Unable to obtain a healthy response from the environment being deployed. Please check the logs for more information.

Sentry reported: Command "vapor:health-check" is not defined.

@joedixon
Copy link
Contributor Author

Thanks for reporting. Vapor will only run vapor:health-check if it detects a compatible version of Vapor Core in the composer.json file, so it seems as though there was a version mismatch somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants