Upgrade to Vite 6 #310

timacdonald · 2024-11-26T22:56:41Z

Upgrades supported Vite version to the recently released Vite 6.

Read more: https://vite.dev/blog/announcing-vite6

Breeze testing

Jetstream testing

Vue
Livewire

Related PRs

timacdonald · 2024-11-26T22:59:38Z

package.json

-        "vite": "^5.0.0",
+        "vite": "^6.0.0",
        "vitest": "^0.34.4"
    },
    "peerDependencies": {
-        "vite": "^5.0.0"


Bumped this straight to v6 instead of support both v5 and v6.

The Vite plugin is extremely stable and is feature complete.

I don't think we need to support both versions. You can stay on the current version until you are ready to update to Vite 6.

This will help keep our maintenance cost to a minimum.

Wouldn’t that make it to version 2?

Not according to semver.

See: https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api

You will need to upgrade to Vite 6 in your own project.

Since the laravel-vite-plugin is not a standalone and requires vite to work, I’d consider the drop of Vite 5 to be a breaking change.

It becomes quickly complicated for users if they have to wonder if any minor/patch update will stop to work with their current setup. I would prefer a breaking, it sends a clearer signal.

What do you think?

just ran npm update (after v1.1.0 was released) and got this...

npm error code ERESOLVE npm error ERESOLVE unable to resolve dependency tree npm error npm error While resolving: undefined@undefined npm error Found: vite@5.4.11 npm error node_modules/vite npm error dev vite@"^5.4.10" from the root project npm error npm error Could not resolve dependency: npm error peer vite@"^6.0.0" from laravel-vite-plugin@1.1.0 npm error node_modules/laravel-vite-plugin npm error dev laravel-vite-plugin@"^1.0.5" from the root project npm error npm error Fix the upstream dependency conflict, or retry npm error this command with --force or --legacy-peer-deps npm error to accept an incorrect (and potentially broken) dependency resolution.

I also get the same message

Make sure to change the vite version to "vite": "^6.0" in your package.json file. Then you should be able to update.

kunalbedi · 2024-11-28T10:29:53Z

When is this PR getting merged. Asking politely! ..
Dependabot going crazy sending me emails. 🥺 😄

thorst · 2024-11-30T00:01:11Z

When I run npm run dev i get this warning Deprecation Warning: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0. are others getting that? I think this PR may fix my issues?

Manoz · 2024-12-02T11:32:35Z

When I run npm run dev i get this warning Deprecation Warning: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0. are others getting that? I think this PR may fix my issues?

This probably has to do with the fact that you have a SASS dependency somewhere on your project.

It should have nothing to do with Vite.js or laravel-vite-plugin.

Moraiene · 2024-12-02T14:03:29Z

When I run npm run dev i get this warning Deprecation Warning: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0. are others getting that? I think this PR may fix my issues?

This probably has to do with the fact that you have a SASS dependency somewhere on your project.

It should have nothing to do with Vite.js or laravel-vite-plugin.

This is directly related to the vitе, because by default sass compilation is used "legacy", for fix this warning need to set option in config to "modern-compiler" in vite 6 default compilation - "modern-compiler"

Moraiene · 2024-12-02T14:04:36Z

When I run npm run dev i get this warning Deprecation Warning: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0. are others getting that? I think this PR may fix my issues?

add to config this

    css: {
        preprocessorOptions: {
            scss: {
                api: 'modern-compiler',
            },
        },
    },

thorst · 2024-12-02T15:08:21Z

Yes @Moraiene you are correct. Once I put that in, it fixed it. I was close. I had the css>preprocessorOptions>scss block and had traced it to this plugin (because it requires vite 5) but I got stuck there.

Once I put in your api parameter, the warning goes away. There were A LOT of import that I had to change to use, and then some pathing issues (like map.has-key instead of map-has-key). Glad those upgrades are out of the way.

Thanks again!!!

Pixel-Navigators · 2024-12-02T19:28:53Z

I am getting this error when I run laravel new example-app as well because of the version change

thorst · 2024-12-02T20:44:59Z

@Pixel-Navigators Same, but if you change vite to 6 in your package.json itll work:

{
    "private": true,
    "type": "module",
    "scripts": {
        "dev": "vite",
        "build": "vite build"
    },
    "devDependencies": {
        "laravel-vite-plugin": "^1.0.6",
        "sass": "^1.81.0",
        "vite": "^6"
    },
    "dependencies": {
        "sass-loader": "^12.6.0"
    }
}

thorst · 2024-12-02T20:47:01Z

Thanks for the merge @taylorotwell now I dont need the fix by @Moraiene, and I dont get build warnings anymore...yay!

fruske · 2024-12-02T22:45:53Z

I am getting this error when I run laravel new example-app as well because of the version change

@Pixel-Navigators I found out the same. I opened a bug @ https://github.com/laravel/installer

Upgrade to Vite 6

b3414bc

timacdonald commented Nov 26, 2024

View reviewed changes

timacdonald marked this pull request as ready for review November 27, 2024 00:48

LucWollants mentioned this pull request Dec 2, 2024

Bump vite from 5.4.11 to 6.0.1 cultuurnet/publiq-platform#1563

Closed

taylorotwell merged commit 492c068 into 1.x Dec 2, 2024
6 checks passed

taylorotwell deleted the vite-6 branch December 2, 2024 15:51

fruske mentioned this pull request Dec 2, 2024

Could not resolve vite dependency laravel/installer#367

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Vite 6 #310

Upgrade to Vite 6 #310

timacdonald commented Nov 26, 2024 •

edited

Loading

timacdonald Nov 26, 2024 •

edited

Loading

laserhybiz Nov 27, 2024

timacdonald Nov 27, 2024

meduzen Nov 29, 2024 •

edited

Loading

laserhybiz Dec 2, 2024

raonsama Dec 2, 2024

elvisblanco1993 Dec 2, 2024 •

edited

Loading

kunalbedi commented Nov 28, 2024

thorst commented Nov 30, 2024

Manoz commented Dec 2, 2024

Moraiene commented Dec 2, 2024

Moraiene commented Dec 2, 2024 •

edited

Loading

thorst commented Dec 2, 2024

Pixel-Navigators commented Dec 2, 2024

thorst commented Dec 2, 2024 •

edited

Loading

thorst commented Dec 2, 2024

fruske commented Dec 2, 2024 •

edited

Loading

Upgrade to Vite 6 #310

Upgrade to Vite 6 #310

Conversation

timacdonald commented Nov 26, 2024 • edited Loading

Breeze testing

Jetstream testing

Related PRs

timacdonald Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

laserhybiz Nov 27, 2024

Choose a reason for hiding this comment

timacdonald Nov 27, 2024

Choose a reason for hiding this comment

meduzen Nov 29, 2024 • edited Loading

Choose a reason for hiding this comment

laserhybiz Dec 2, 2024

Choose a reason for hiding this comment

raonsama Dec 2, 2024

Choose a reason for hiding this comment

elvisblanco1993 Dec 2, 2024 • edited Loading

Choose a reason for hiding this comment

kunalbedi commented Nov 28, 2024

thorst commented Nov 30, 2024

Manoz commented Dec 2, 2024

Moraiene commented Dec 2, 2024

Moraiene commented Dec 2, 2024 • edited Loading

thorst commented Dec 2, 2024

Pixel-Navigators commented Dec 2, 2024

thorst commented Dec 2, 2024 • edited Loading

thorst commented Dec 2, 2024

fruske commented Dec 2, 2024 • edited Loading

timacdonald commented Nov 26, 2024 •

edited

Loading

timacdonald Nov 26, 2024 •

edited

Loading

meduzen Nov 29, 2024 •

edited

Loading

elvisblanco1993 Dec 2, 2024 •

edited

Loading

Moraiene commented Dec 2, 2024 •

edited

Loading

thorst commented Dec 2, 2024 •

edited

Loading

fruske commented Dec 2, 2024 •

edited

Loading