Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change qemu test scripts by using a new bazel rule #533

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Change qemu test scripts by using a new bazel rule #533

merged 2 commits into from
Oct 14, 2020

Conversation

Tombana
Copy link
Collaborator

@Tombana Tombana commented Oct 14, 2020

What do these changes do?

The old qemu test scripts would glob (*) for all *_test files in a directory. This PR adds a lce_qemu_test_suite bazel rule that will create individual bazel test targets for all binaries so that the script can simply run one binary.

How Has This Been Tested?

CI

@Tombana Tombana requested a review from a team October 14, 2020 12:35
lgeiger
lgeiger approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@lgeiger lgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup 🚀

@lgeiger lgeiger merged commit 3683a7c into master Oct 14, 2020
@lgeiger lgeiger deleted the qemu_tests branch October 14, 2020 13:17
@lgeiger lgeiger added the internal-improvement Internal Improvements and Maintenance label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgeiger lgeiger lgeiger approved these changes

Assignees
No one assigned
Labels
internal-improvement Internal Improvements and Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tombana @lgeiger