Add zero-padding support to the reference kernel #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tombana
commented
Nov 20, 2020
AdamHillier
reviewed
Nov 20, 2020
AdamHillier
approved these changes
Nov 20, 2020
|
@lkindrat-xmos This might be relevant to you for internal testing. You can now run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR adds zero-padding support to the reference kernel, for all output types, group sizes, and activation functions.
(Previously we only supported zero-padding for the regular float kernel with no activation functions and no groups.)
Furthermore the
LiteInterpreternow has an extra argument to choose the reference kernel, in order to be able to test against zero-padding.How Has This Been Tested?
The bconv2d tests have been updated.