-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows release builds. #590
Conversation
b279716
to
882272d
Compare
Test release run: https://github.com/larq/compute-engine/runs/1761598156 |
The Windows builds succeeded here, but the Linux ones failed. @lgeiger do you think this is related to this PR? |
Great news on the Windows builds! The Linux failures could either be related to #589 since we are now hardcoding the Python env variables or it could be due to a change in the Dockerfile. |
882272d
to
5099c05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for debugging this 🙏
5099c05
to
68c2822
Compare
68c2822
to
fb6f15a
Compare
I ran a build with the updated code last night and everything is now green, including the Linux builds, so I think this is good to go: https://github.com/larq/compute-engine/actions/runs/510137328 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for fixing the build 🚀
What do these changes do?
This PR (hopefully) fixes the Windows release builds, by copying in the most recent Windows build config from TensorFlow, using some extra commands that reduce memory usage, and increasing the size of the pagefile (swapfile).
How Has This Been Tested?
I will trigger a nightly release from this branch.
Benchmark Results
N/A.
Related issue number
Relies on #589.