Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manylinux container from CI #670

Merged
merged 3 commits into from
Jun 24, 2021
Merged

Remove manylinux container from CI #670

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a04141
Remove manylinux container from CI
Tombana Jun 24, 2021
5af61c1
Add `pip install numpy`
Tombana Jun 24, 2021
c09fbdf
Update checkout action
Tombana Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions .github/workflows/unittests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,20 @@ jobs:
TFLite:
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, 'ci-skip')"
container:
image: tensorflow/tensorflow:2.2.0-custom-op-ubuntu16

steps:
- uses: actions/checkout@v1
with:
submodules: true
- name: Install Bazelisk
run: |
curl -L https://github.com/bazelbuild/bazelisk/releases/download/v1.7.4/bazelisk-linux-amd64 > bazelisk
chmod +x bazelisk
- uses: actions/setup-python@v2
with:
python-version: 3.9
- name: Configure Bazel
run: ./configure.py
shell: bash
env:
MANYLINUX2010: 1
# CC unit tests needs to run after the configure is finished
# since the CC builds rely on compiler options generated by configure.
- name: Run TFLite Ops and Core CC Unit Tests
run: ./bazelisk test larq_compute_engine/tests:cc_tests --copt=-O2 --distinct_host_configuration=false --test_output=all
- name: Install pip dependencies
run: pip install numpy --no-cache-dir
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also used to also need six for TF to build properly. Not sure if this is still the case.

Suggested change
run: pip install numpy --no-cache-dir
run: pip install numpy six --no-cache-dir

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip, lets see what CI does.

- name: Run C++ Unit Tests
run: bazelisk test larq_compute_engine/tests:cc_tests --copt=-O2 --distinct_host_configuration=false --test_output=all
- name: Build TF Lite Static Library with Make
run: larq_compute_engine/tflite/build_make/build_lce.sh --native

Expand Down