Simplify Python Linux wheel release scripts #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tombana
approved these changes
Jan 12, 2022
lgeiger
approved these changes
Jan 12, 2022
lgeiger
added
breaking-change
lgeiger
approved these changes
Jan 12, 2022
lgeiger
added
internal-improvement
|
I'm merging this one in. The relevant builds have passed in a test release (https://github.com/larq/compute-engine/actions/runs/1686835008), although some others timed out due to a GitHub Actions time limit of 6 hours. |
This was referenced Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This simplifies the release scripts for the larq-compute-engine Python wheel converter for Linux. This is based on the latest simplified method from tf-addons release system to build the larq-compute-engine wheel. The previous scripts resulted in issues, most likely due to running out of memory.
The implications are that this drops support for Python 3.6, since there is no corresponding Docker image available. It also relies on the 'latest' tag, which could result in things suddenly not working anymore as 'latest' changes due to a TensorFlow update. However, the advantage is that we always use the latest images.
This PR requires updating the docs separately.
How Has This Been Tested?
We'll need to do a test release on this branch before merging in. A test run is currently in progress here:
https://github.com/larq/compute-engine/actions/runs/1686835008