Remove weak attribute for RegisterSelectedOps
#734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The bazel build of
lce_benchmark_modelworks fine, but when using the cmake version, none of our ops are registered:RegisterSelectedOpsis not called at all. This seems to be caused by the fact that the registration function is marked as 'weak', and then it depends on the order of linking which function wins.There wasn't supposed to be a weak attribute here at all: the weak version of the symbol is in the TF library, meant to be overridden by binaries such as this one.
How Has This Been Tested?
Both the cmake and bazel builds are now working as expected.