Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove anonymous namespaces in MLIR transforms #768

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

Tombana
Copy link
Collaborator

@Tombana Tombana commented Feb 20, 2023

What do these changes do?

This fixes the following type of runtime errors when the converter is built with clang.

LLVM ERROR: TypeID::get<mlir::TFL::(anonymous namespace)::FusePadding>(): Using TypeID on a class with an anonymous namespace requires an explicit TypeID definition. The implicit fallback uses string name, which does not guarantee uniqueness in anonymous contexts. Define an explicit TypeID instantiation for this type using `MLIR_DECLARE_EXPLICIT_TYPE_ID`/`MLIR_DEFINE_EXPLICIT_TYPE_ID` or `MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID`.

@Tombana Tombana requested a review from a team February 20, 2023 10:40
@Tombana Tombana enabled auto-merge (squash) February 20, 2023 10:46
@Tombana Tombana added the internal-improvement Internal Improvements and Maintenance label Feb 20, 2023
@Tombana Tombana merged commit 9a77138 into main Feb 20, 2023
@Tombana Tombana deleted the mlir_namespaces branch February 20, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-improvement Internal Improvements and Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants