cleanup (#52)

larshp · Apr 12, 2024 · 300aad2 · 300aad2
1 parent 32e67e8
commit 300aad2
Show file tree

Hide file tree

Showing 99 changed files with 376 additions and 469 deletions.
diff --git a/abaplint.json b/abaplint.json
@@ -1,9 +1,6 @@
 {
   "global": {
-    "files": "/src/**/*.*",
-    "skipGeneratedGatewayClasses": true,
-    "skipGeneratedPersistentClasses": true,
-    "skipGeneratedFunctionGroups": true
+    "files": "/src/**/*.*"
   },
   "dependencies": [
     {
@@ -24,9 +21,7 @@
   ],
   "syntax": {
     "version": "v702",
-    "errorNamespace": "^(Z|Y|LCL_|TY_|LIF_)",
-    "globalConstants": [],
-    "globalMacros": []
+    "errorNamespace": "^(Z|Y|LCL_|TY_|LIF_)"
   },
   "rules": {
     "align_parameters": false,
@@ -60,7 +55,7 @@
     "slow_parameter_passing": true,
     "static_call_via_instance": true,
     "superfluous_value": true,
-    "unnecessary_chaining": false,
+    "unnecessary_chaining": true,
     "unnecessary_pragma": true,
     "unsecure_fae": true,
     "use_class_based_exceptions": true,
@@ -189,20 +184,9 @@
       "ignoreGlobalInterface": false
     },
     "inline_data_old_versions": true,
-    "keep_single_parameter_on_one_line": false,
-    "keyword_case": {
-      "style": "upper",
-      "ignoreExceptions": true,
-      "ignoreLowerClassImplmentationStatement": true,
-      "ignoreGlobalClassBoundaries": false,
-      "ignoreGlobalClassDefinition": false,
-      "ignoreGlobalInterface": false,
-      "ignoreFunctionModuleName": false,
-      "ignoreKeywords": []
-    },
-    "line_length": {
-      "length": 120
-    },
+    "keep_single_parameter_on_one_line": true,
+    "keyword_case": true,
+    "line_length": true,
     "line_only_punc": {
       "ignoreExceptions": true
     },
@@ -301,23 +285,13 @@
     },
     "parser_error": true,
     "prefer_returning_to_exporting": true,
-    "preferred_compare_operator": {
-      "badOperators": [
-        "EQ",
-        "><",
-        "NE",
-        "GE",
-        "GT",
-        "LT",
-        "LE"
-      ]
-    },
+    "preferred_compare_operator": true,
     "prefix_is_current_class": {
       "omitMeInstanceCalls": true
     },
     "release_idoc": true,
     "unused_ddic": true,
-    "remove_descriptions": false,
+    "remove_descriptions": true,
     "rfc_error_handling": true,
     "selection_screen_naming": true,
     "sequential_blank": {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -20,8 +20,8 @@
   "homepage": "https://github.com/larshp/abapPGP#readme",
   "dependencies": {
     "@abaplint/cli": "^2.106.5",
-    "@abaplint/runtime": "^2.8.22",
+    "@abaplint/runtime": "^2.8.23",
     "0x": "^5.7.0",
-    "@abaplint/transpiler-cli": "^2.8.22"
+    "@abaplint/transpiler-cli": "^2.8.23"
   }
 }
diff --git a/src/integer/zcl_abappgp_binary_integer.clas.abap b/src/integer/zcl_abappgp_binary_integer.clas.abap
@@ -97,7 +97,7 @@ CLASS zcl_abappgp_binary_integer IMPLEMENTATION.
 
   METHOD constructor.
 
-    DATA: lo_int TYPE REF TO zcl_abappgp_integer.
+    DATA lo_int TYPE REF TO zcl_abappgp_integer.
 
     IF go_two IS INITIAL.
       CREATE OBJECT go_two
@@ -131,7 +131,7 @@ CLASS zcl_abappgp_binary_integer IMPLEMENTATION.
 
   METHOD from_string.
 
-    DATA: lo_integer TYPE REF TO zcl_abappgp_integer.
+    DATA lo_integer TYPE REF TO zcl_abappgp_integer.
 
 
     lo_integer = zcl_abappgp_integer=>from_string( iv_string ).
@@ -159,7 +159,7 @@ CLASS zcl_abappgp_binary_integer IMPLEMENTATION.
 
   METHOD mod_2.
 
-    DATA: lv_length TYPE i.
+    DATA lv_length TYPE i.
 
     lv_length = strlen( mv_data ) - 1.
 
@@ -187,7 +187,7 @@ CLASS zcl_abappgp_binary_integer IMPLEMENTATION.
 
   METHOD shift_right.
 
-    DATA: lv_length TYPE i.
+    DATA lv_length TYPE i.
 
     ASSERT iv_times >= 1.
 

diff --git a/src/integer/zcl_abappgp_binary_integer.clas.testclasses.abap b/src/integer/zcl_abappgp_binary_integer.clas.testclasses.abap
@@ -9,7 +9,7 @@ CLASS ltcl_and DEFINITION FOR TESTING
       and2 FOR TESTING,
       and3 FOR TESTING.
 
-    METHODS:
+    METHODS
       test IMPORTING iv_op1           TYPE string
                      iv_op2           TYPE string
            RETURNING VALUE(rv_result) TYPE string.
@@ -33,7 +33,7 @@ CLASS ltcl_and IMPLEMENTATION.
 
   METHOD and1.
 
-    DATA: lv_result TYPE string.
+    DATA lv_result TYPE string.
 
     lv_result = test( iv_op1 = '16'
                       iv_op2 = '16' ).
@@ -46,7 +46,7 @@ CLASS ltcl_and IMPLEMENTATION.
 
   METHOD and2.
 
-    DATA: lv_result TYPE string.
+    DATA lv_result TYPE string.
 
     lv_result = test( iv_op1 = '32'
                       iv_op2 = '16' ).
@@ -59,7 +59,7 @@ CLASS ltcl_and IMPLEMENTATION.
 
   METHOD and3.
 
-    DATA: lv_result TYPE string.
+    DATA lv_result TYPE string.
 
     lv_result = test( iv_op1 = '48'
                       iv_op2 = '16' ).
@@ -79,10 +79,10 @@ CLASS ltcl_mod DEFINITION FOR TESTING
     FINAL.
 
   PRIVATE SECTION.
-    METHODS:
+    METHODS
       mod1 FOR TESTING.
 
-    METHODS:
+    METHODS
       test IMPORTING iv_str           TYPE string
            RETURNING VALUE(rv_result) TYPE i.
 
@@ -92,7 +92,7 @@ CLASS ltcl_mod IMPLEMENTATION.
 
   METHOD test.
 
-    DATA: lo_binary  TYPE REF TO zcl_abappgp_binary_integer.
+    DATA lo_binary  TYPE REF TO zcl_abappgp_binary_integer.
 
 
     lo_binary = zcl_abappgp_binary_integer=>from_string( iv_str ).
@@ -102,7 +102,7 @@ CLASS ltcl_mod IMPLEMENTATION.
 
   METHOD mod1.
 
-    DATA: lv_result TYPE i.
+    DATA lv_result TYPE i.
 
     lv_result = test( '3' ).
 
@@ -121,10 +121,10 @@ CLASS ltcl_shift_right DEFINITION FOR TESTING
     FINAL.
 
   PRIVATE SECTION.
-    METHODS:
+    METHODS
       shift1 FOR TESTING.
 
-    METHODS:
+    METHODS
       test IMPORTING iv_str        TYPE string
            RETURNING VALUE(rv_str) TYPE string.
 
@@ -134,7 +134,7 @@ CLASS ltcl_shift_right IMPLEMENTATION.
 
   METHOD test.
 
-    DATA: lo_binary TYPE REF TO zcl_abappgp_binary_integer.
+    DATA lo_binary TYPE REF TO zcl_abappgp_binary_integer.
 
 
     lo_binary = zcl_abappgp_binary_integer=>from_string( iv_str ).
@@ -145,7 +145,7 @@ CLASS ltcl_shift_right IMPLEMENTATION.
 
   METHOD shift1.
 
-    DATA: lv_result TYPE string.
+    DATA lv_result TYPE string.
 
     lv_result = test( '16' ).
 
@@ -169,15 +169,15 @@ CLASS ltcl_identity DEFINITION FOR TESTING
       identity3 FOR TESTING,
       identity4 FOR TESTING.
 
-    METHODS: test IMPORTING iv_input TYPE string.
+    METHODS test IMPORTING iv_input TYPE string.
 
 ENDCLASS.       "ltcl_Get
 
 CLASS ltcl_identity IMPLEMENTATION.
 
   METHOD test.
 
-    DATA: lo_binary  TYPE REF TO zcl_abappgp_binary_integer.
+    DATA lo_binary  TYPE REF TO zcl_abappgp_binary_integer.
 
 
     lo_binary = zcl_abappgp_binary_integer=>from_string( iv_input ).
@@ -222,7 +222,7 @@ CLASS ltcl_to_binary_string DEFINITION FOR TESTING
       get7 FOR TESTING,
       get8 FOR TESTING.
 
-    METHODS: test IMPORTING iv_str           TYPE string
+    METHODS test IMPORTING iv_str           TYPE string
                   RETURNING VALUE(rv_binary) TYPE string.
 
 ENDCLASS.       "ltcl_Get
@@ -231,7 +231,7 @@ CLASS ltcl_to_binary_string IMPLEMENTATION.
 
   METHOD test.
 
-    DATA: lo_binary TYPE REF TO zcl_abappgp_binary_integer.
+    DATA lo_binary TYPE REF TO zcl_abappgp_binary_integer.
 
 
     lo_binary = zcl_abappgp_binary_integer=>from_string( iv_str ).
@@ -241,7 +241,7 @@ CLASS ltcl_to_binary_string IMPLEMENTATION.
 
   METHOD get1.
 
-    DATA: lv_binary TYPE string.
+    DATA lv_binary TYPE string.
 
     lv_binary = test( '16' ).
 
@@ -253,7 +253,7 @@ CLASS ltcl_to_binary_string IMPLEMENTATION.
 
   METHOD get2.
 
-    DATA: lv_binary TYPE string.
+    DATA lv_binary TYPE string.
 
     lv_binary = test( '1234' ).
 
@@ -265,7 +265,7 @@ CLASS ltcl_to_binary_string IMPLEMENTATION.
 
   METHOD get3.
 
-    DATA: lv_binary TYPE string.
+    DATA lv_binary TYPE string.
 
     lv_binary = test( '1' ).
 
@@ -277,7 +277,7 @@ CLASS ltcl_to_binary_string IMPLEMENTATION.
 
   METHOD get4.
 
-    DATA: lv_binary TYPE string.
+    DATA lv_binary TYPE string.
 
     lv_binary = test( '8191' ).
 
@@ -289,7 +289,7 @@ CLASS ltcl_to_binary_string IMPLEMENTATION.
 
   METHOD get5.
 
-    DATA: lv_binary TYPE string.
+    DATA lv_binary TYPE string.
 
     lv_binary = test( '8192' ).
 
@@ -301,7 +301,7 @@ CLASS ltcl_to_binary_string IMPLEMENTATION.
 
   METHOD get6.
 
-    DATA: lv_binary TYPE string.
+    DATA lv_binary TYPE string.
 
     lv_binary = test( '8193' ).
 
@@ -313,7 +313,7 @@ CLASS ltcl_to_binary_string IMPLEMENTATION.
 
   METHOD get7.
 
-    DATA: lv_binary TYPE string.
+    DATA lv_binary TYPE string.
 
     lv_binary = test( '9000' ).
 
@@ -325,7 +325,7 @@ CLASS ltcl_to_binary_string IMPLEMENTATION.
 
   METHOD get8.
 
-    DATA: lv_binary TYPE string.
+    DATA lv_binary TYPE string.
 
     lv_binary = test( '10000' ).