(sqlx-macros) Ignore deps when getting metadata for workspace root #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using compile-time queries in a workspace with a single
sqlx-data.jsonfile in the workspace root the following code is run to get the path to the workspace root. Because we only need the workspace root we can ignore dep information which ends up being a small, but significant changeI setup a minimal test environment with a single crate in a workspace. Here are the timings of an incremental unchanged
cargo checkmaster(ec15f6b)I also tested with a workspace that had two crates compiled linearly, and the difference there came out to be roughly 40 ms per crate too