Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i16 support for Any Type. #1895

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Conversation

EthanYuan
Copy link
Contributor

All four databases of PostgreSQL, MySQL, SQLite, and MSSQL supported by SQLx support i16 Type, but Any Type's support for i16 seems to be missing.

@EthanYuan EthanYuan changed the title Add i16 support for Any Type. Add i16 support for Any Type. Jun 7, 2022
@abonander
Copy link
Collaborator

Looks like a test needs to be fixed because the new Encode impl introduced a method resolution ambiguity: https://github.com/launchbadge/sqlx/runs/6782170035?check_suite_focus=true#step:7:108

I don't consider this a breaking change but this will be part of 0.6.0 anyway so it's not a big deal.

@EthanYuan
Copy link
Contributor Author

I don't consider this a breaking change but this will be part of 0.6.0 anyway so it's not a big deal.

Great, I'm looking forward to 0.6.0.

@abonander abonander merged commit edaf7d0 into launchbadge:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants