-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: agree one a single default runtime for the whole workspace #1988
Conversation
Could you explain why changing the runtime to async-std helps? |
I'm not entirely sure what depends on what in this workspace, but it seems the members at least don't agree on the defaults: https://github.com/launchbadge/sqlx/blob/main/sqlx-macros/Cargo.toml#L19 So the Cargo feature unification will pick both tokio and async-std for the RT crate, which then will fail to compile. |
If we have to standardize on a single default runtime for the whole workspace, I'd prefer it to be Tokio. |
Which would mean adjusting all the examples as well (because there the de facto standard is currently async-std), for which I currently don't have the resources, esp. since compiling them requires quite some manual labor. |
Yeah, most of those examples were initially authored when SQLx was exclusively for use with async-std. Since then, the async ecosystem has pretty much centered around Tokio and so it would make more sense to port the examples over as well. For the most part, it should only require some find-and-replace operations, and you can just let CI build it for you. |
I'll see if I find some time this week. On the first glance, the |
Clap's API is not completely the same as structopt, removing paw alone may be easier. |
This fixes `cargo check --workspace` and rust-analyzer. Also see <launchbadge#1956>.
e0611d3
to
8729e75
Compare
This is now ready to review. |
Thanks for going the extra mile. I really appreciate it. |
As a mere user I appreciate it too! ❤️ |
This fixes
cargo check --workspace
and rust-analyzer.Also see #1956.