Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQLite] Add option to execute PRAGMA optimize; on close of a connection #2116

Merged
merged 6 commits into from
Feb 15, 2023

Conversation

miles170
Copy link
Contributor

Closes #2111.

sqlx-core/src/sqlite/connection/mod.rs Outdated Show resolved Hide resolved
sqlx-core/src/sqlite/options/connect.rs Outdated Show resolved Hide resolved
sqlx-core/src/sqlite/connection/mod.rs Outdated Show resolved Hide resolved
sqlx-core/src/sqlite/options/mod.rs Outdated Show resolved Hide resolved
sqlx-core/src/sqlite/options/mod.rs Outdated Show resolved Hide resolved
@miles170 miles170 requested review from abonander and paolobarbolini and removed request for paolobarbolini and abonander October 3, 2022 01:47
@abonander abonander changed the base branch from main to 0.7-dev February 8, 2023 19:21
@abonander
Copy link
Collaborator

@miles170 sorry for the long delay, I've changed the base to 0.7-dev as that's where all development work has been taking place. Do you mind rebasing?

The big change is that the SQLite driver is now in its own separate crate/folder.

@abonander
Copy link
Collaborator

@miles170 I fixed the merge conflicts, can you run cargo fmt?

@abonander abonander merged commit 7d6d502 into launchbadge:0.7-dev Feb 15, 2023
@abonander
Copy link
Collaborator

Glad to finally land this, thanks!

abonander added a commit that referenced this pull request Feb 18, 2023
…ction (#2116)

* CHANGELOG: mention that users should upgrade CLI

* [SQLite] Add option to execute `PRAGMA optimize;` on close of a connection

* Update sqlx-sqlite/src/options/mod.rs

* Update sqlx-sqlite/src/options/mod.rs

* Update sqlx-sqlite/src/options/mod.rs

---------

Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
abonander added a commit that referenced this pull request Feb 21, 2023
…ction (#2116)

* CHANGELOG: mention that users should upgrade CLI

* [SQLite] Add option to execute `PRAGMA optimize;` on close of a connection

* Update sqlx-sqlite/src/options/mod.rs

* Update sqlx-sqlite/src/options/mod.rs

* Update sqlx-sqlite/src/options/mod.rs

---------

Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Aandreba pushed a commit to Aandreba/sqlx that referenced this pull request Mar 31, 2023
…ction (launchbadge#2116)

* CHANGELOG: mention that users should upgrade CLI

* [SQLite] Add option to execute `PRAGMA optimize;` on close of a connection

* Update sqlx-sqlite/src/options/mod.rs

* Update sqlx-sqlite/src/options/mod.rs

* Update sqlx-sqlite/src/options/mod.rs

---------

Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SQLite] Add option to execute PRAGMA optimize; on close of a connection
3 participants