-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQLite] Add option to execute PRAGMA optimize;
on close of a connection
#2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles170
requested review from
paolobarbolini
and removed request for
paolobarbolini
September 25, 2022 04:12
abonander
requested changes
Sep 27, 2022
abonander
requested changes
Oct 1, 2022
miles170
requested review from
abonander and
paolobarbolini
and removed request for
paolobarbolini and
abonander
October 3, 2022 01:47
@miles170 sorry for the long delay, I've changed the base to The big change is that the SQLite driver is now in its own separate crate/folder. |
abonander
reviewed
Feb 14, 2023
abonander
reviewed
Feb 14, 2023
@miles170 I fixed the merge conflicts, can you run |
Glad to finally land this, thanks! |
abonander
added a commit
that referenced
this pull request
Feb 18, 2023
…ction (#2116) * CHANGELOG: mention that users should upgrade CLI * [SQLite] Add option to execute `PRAGMA optimize;` on close of a connection * Update sqlx-sqlite/src/options/mod.rs * Update sqlx-sqlite/src/options/mod.rs * Update sqlx-sqlite/src/options/mod.rs --------- Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
abonander
added a commit
that referenced
this pull request
Feb 21, 2023
…ction (#2116) * CHANGELOG: mention that users should upgrade CLI * [SQLite] Add option to execute `PRAGMA optimize;` on close of a connection * Update sqlx-sqlite/src/options/mod.rs * Update sqlx-sqlite/src/options/mod.rs * Update sqlx-sqlite/src/options/mod.rs --------- Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Aandreba
pushed a commit
to Aandreba/sqlx
that referenced
this pull request
Mar 31, 2023
…ction (launchbadge#2116) * CHANGELOG: mention that users should upgrade CLI * [SQLite] Add option to execute `PRAGMA optimize;` on close of a connection * Update sqlx-sqlite/src/options/mod.rs * Update sqlx-sqlite/src/options/mod.rs * Update sqlx-sqlite/src/options/mod.rs --------- Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2111.