Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to make Postgres's begin step more cancel safe than it used to be.
begin
is overkill, so I have switched to using the simple query protocol like sqlx uses in drop-rollback - this is inspired by tokio-postgres.wait_until_ready
Because we guarantee to write a BEGIN/SAVEPOINT to the PgStream, any drops will definitely rollback to that point and not to a parent BEGIN. The previous impl could be cancelled at the prepare/bind and not need to be rolled back, so applying this drop guard would not be so safe
cc #2805