feat: add raw_sql API
#3007
Merged
feat: add raw_sql API
#3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
force-pushed
the
ab/raw-sql-api
branch
3 times, most recently
from
c6ab5a0
to
ea75b92
Compare
|
Not sure how useful this piece of feedback is, but from what I could gather when skimming the diff, this (mainly the updated documentation) is a massive QoL improvement and while I didn't personally need it, I can see how it will make SQLx a lot more approachable for some people! |
abonander
force-pushed
the
ab/raw-sql-api
branch
3 times, most recently
from
7cb8f6c
to
300da2a
Compare
abonander
force-pushed
the
ab/raw-sql-api
branch
7 times, most recently
from
367d65a
to
d138ced
Compare
abonander
force-pushed
the
ab/raw-sql-api
branch
2 times, most recently
from
b5dabaf
to
06aa038
Compare
This is meant to be much easier to discover than the current approach of directly invoking `Executor` methods. In addition, I'm improving documentation for the `query*()` functions across the board.
abonander
force-pushed
the
ab/raw-sql-api
branch
from
06aa038
to
b01d530
Compare
|
Changed some tests to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to be much easier to discover than the current approach of directly invoking
Executormethods.In addition, I'm improving documentation for the
query*()functions across the board.This also deprecates
.execute_many()and.fetch_many()on these types because only the SQLite driver actually ever supported multiple statements in a single query string with the prepared statement interface, and that's just a consequence of the fact that it handles all statements as prepared statements.