Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default implementation for PgInterval #3013

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Add default implementation for PgInterval #3013

merged 1 commit into from
Jan 26, 2024

Conversation

pawurb
Copy link
Contributor

@pawurb pawurb commented Jan 24, 2024

I've noticed that compared all other sqlx data types PgInterval does not implement Default trait. As a result it's not possible to use methods like unwrap_or_default() with this data type.

This PR adds PgInterval::default() implementation.

@abonander abonander merged commit af31d50 into launchbadge:main Jan 26, 2024
64 checks passed
@pawurb pawurb deleted the pg_interval_default branch January 26, 2024 09:02
@pawurb pawurb mentioned this pull request Jan 26, 2024
Merged
kukabi pushed a commit to helikon-labs/sqlx that referenced this pull request Feb 22, 2024
@pawurb @kukabi
Add default implementation for PgInterval (launchbadge#3013)
8bda997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawurb @abonander