Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove BoxFuture's (non-breaking) #3629

Merged
merged 3 commits into from
Dec 12, 2024
Merged

chore: remove BoxFuture's (non-breaking) #3629

merged 3 commits into from
Dec 12, 2024
+122 −132

Conversation

joeydewaal
Copy link
Contributor

@joeydewaal joeydewaal commented Dec 6, 2024 •
edited
Loading

  • Since rust 1.77 recursion in async functions is supported. This pr removes a few BoxFuture's now that these are not necessary anymore.
  • Also removes BoxFuture's in the WithSocket trait which should not be a breaking change.

@joeydewaal joeydewaal changed the title chore: reduce BoxFuture's when using recursion. chore: remove BoxFuture's (non-breaking) Dec 9, 2024
abonander
abonander requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small nitpicks, otherwise looks good!

sqlx-postgres/src/connection/stream.rs Outdated Show resolved Hide resolved
sqlx-postgres/src/connection/describe.rs Show resolved Hide resolved
@joeydewaal
Copy link
Contributor Author

Thanks for the review, I made the requested changes

@abonander abonander merged commit 1f6ce33 into launchbadge:main Dec 12, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonander abonander abonander requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeydewaal @abonander