fix: Validate string format of SDK key #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonbailey
commented
Sep 26, 2025
jsonbailey
commented
Sep 26, 2025
kinyoklion
reviewed
Sep 26, 2025
jsonbailey
commented
Sep 26, 2025
kinyoklion
reviewed
Sep 26, 2025
kinyoklion
reviewed
Sep 26, 2025
kinyoklion
reviewed
Sep 26, 2025
kinyoklion
reviewed
Sep 26, 2025
kinyoklion
reviewed
Sep 26, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
3 tasks
kinyoklion
approved these changes
Sep 29, 2025
This was referenced Sep 29, 2025
jsonbailey
pushed a commit
that referenced
this pull request
Sep 29, 2025
🤖 I have created a release *beep* *boop* --- ## [8.10.3](LaunchDarkly.ServerSdk-v8.10.2...LaunchDarkly.ServerSdk-v8.10.3) (2025-09-29) ### Bug Fixes * Validate string format of SDK key ([#162](#162)) ([27a26fb](27a26fb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jsonbailey
pushed a commit
that referenced
this pull request
Sep 29, 2025
🤖 I have created a release *beep* *boop* --- ## [5.5.4](LaunchDarkly.ClientSdk-v5.5.3...LaunchDarkly.ClientSdk-v5.5.4) (2025-09-29) ### Bug Fixes * Validate string format of SDK key ([#162](#162)) ([27a26fb](27a26fb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Bumps client SDK to 5.5.4 and updates changelog with bug fix for SDK key string format validation. > > - **Client SDK (`pkgs/sdk/client`)**: > - **Version bump**: Update `LaunchDarkly.ClientSdk.csproj` `<Version>` from `5.5.3` to `5.5.4`. > - **Changelog**: Add `5.5.4` entry noting bug fix to validate SDK key string format. > - **Release manifest**: > - Update `.release-please-manifest.json` `pkgs/sdk/client` from `5.5.3` to `5.5.4`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit f859104. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Validate SDK/mobile key strings during configuration; add error log for invalid server key and bump Common/Internal SDK dependencies.
ConfigurationBuilder: validatemobileKeyviaValidationUtils.IsValidSdkKeyFormat; constructors andMobileKey()only set when valid.ConfigurationBuilder: validatesdkKeysimilarly; constructors andSdkKey()only set when valid.LdClient: log an error ifSdkKeyis invalid (null) when not offline.LaunchDarkly.CommonSdkto7.1.1andLaunchDarkly.InternalSdkto3.5.5in client and server projects.using LaunchDarkly.Sdk.Helperswhere validation is used.LdClientListenersTestto use a non-empty SDK key and minor whitespace cleanup.Written by Cursor Bugbot for commit fb77862. This will update automatically on new commits. Configure here.