-
Notifications
You must be signed in to change notification settings - Fork 0
feat: [REL-10443] Developer Toolbar authentication #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ly/launchdarkly-toolbar into cspath/REL-10443-toolbar-auth
…postMessage comms
pranjal-jately-ld
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ace work @cspath1 🙌 The way you've structured the code for auth in the toolbar makes it very easy to follow and understand! ✨ I've left a couple of comments/suggestions.
One thing I am struggling with is testing this branch with the momi branch. I've tried a lot to debug why it might be the case, however I don't see a login/person icon in the toolbar and I'm not sure why that's the case.
Thanks for helping me getting this sorted @cspath1 🙌 This looks ace and I think we can proceed with releasing this to users. I've got some more thoughts/improvements we can make but none are blockers:
|

Description
To unlock the door to developing powerful, meaningful features to the Developer Toolbar, we need a way to allow users to authenticate with LaunchDarkly so the toolbar can access information that requires authentication. Think of features like:
This sets up the foundation and helps unlock that door.
What does this PR do?
Implements an authentication mechanism in tandem with the MoMI repository changes here. This sets up the following, but does not add any inherent new feature that provides value to developers:
Testing
To test this effectively, you first need to follow the setup/testing instructions in the MoMI pull request linked above. Once that is up and running:
AuthenticationModal.tsxso thegetIframeUrlmethod will point to your local MoMI server (hosted via ngrok)Type of Change
Screenshots/Videos
Authentication.Process.Walkthrough.for.MOMI.Integration.mp4
Related Jira issue: REL-10443: Update the Developer Toolbar to use the MoMI repo for authentication