Merge pull request #211 from launchdarkly/eb/sc-181822/preprocess-targets

store flag/segment target lists as sets

Author: eli-darkly

ldclient/impl/evaluator.py

@@ -423,7 +423,7 @@ def _bucketable_string_value(u_value) -> Optional[str]:
 
     return None
 
-def _context_key_is_in_target_list(context: Context, context_kind: Optional[str], keys: Optional[List[str]]) -> bool:
+def _context_key_is_in_target_list(context: Context, context_kind: Optional[str], keys: Set[str]) -> bool:
     if keys is None or len(keys) == 0:
         return False
     match_context = context.get_individual_context(context_kind or Context.DEFAULT_KIND)

ldclient/impl/model/feature_flag.py

@@ -1,4 +1,4 @@
-from typing import Any, List, Optional
+from typing import Any, List, Optional, Set
 
 from ldclient.impl.model.clause import Clause
 from ldclient.impl.model.entity import *
@@ -27,7 +27,7 @@ class Target:
     def __init__(self, data: dict):
         self._context_kind = opt_str(data, 'contextKind')
         self._variation = req_int(data, 'variation')
-        self._values = req_str_list(data, 'values')
+        self._values = set(req_str_list(data, 'values'))
 
     @property
     def context_kind(self) -> Optional[str]:
@@ -38,7 +38,7 @@ def variation(self) -> int:
         return self._variation
 
     @property
-    def values(self) -> List[str]:
+    def values(self) -> Set[str]:
         return self._values
 
 

ldclient/impl/model/segment.py

@@ -1,4 +1,4 @@
-from typing import Any, List, Optional
+from typing import Any, List, Optional, Set
 
 from ldclient.impl.model.attribute_ref import AttributeRef, opt_attr_ref_with_opt_context_kind
 from ldclient.impl.model.clause import Clause
@@ -10,14 +10,14 @@ class SegmentTarget:
 
     def __init__(self, data: dict, logger = None):
         self._context_kind = opt_str(data, 'contextKind')
-        self._values = req_str_list(data, 'values')
+        self._values = set(req_str_list(data, 'values'))
 
     @property
     def context_kind(self) -> Optional[str]:
         return self._context_kind
 
     @property
-    def values(self) -> List[str]:
+    def values(self) -> Set[str]:
         return self._values
 
 
@@ -63,8 +63,8 @@ def __init__(self, data: dict):
         self._deleted = opt_bool(data, 'deleted')
         if self._deleted:
             return
-        self._included = opt_str_list(data, 'included')
-        self._excluded = opt_str_list(data, 'excluded')
+        self._included = set(opt_str_list(data, 'included'))
+        self._excluded = set(opt_str_list(data, 'excluded'))
         self._included_contexts = list(SegmentTarget(item) for item in opt_dict_list(data, 'includedContexts'))
         self._excluded_contexts = list(SegmentTarget(item) for item in opt_dict_list(data, 'excludedContexts'))
         self._rules = list(SegmentRule(item) for item in opt_dict_list(data, 'rules'))
@@ -86,11 +86,11 @@ def deleted(self) -> bool:
         return self._deleted
 
     @property
-    def included(self) -> List[str]:
+    def included(self) -> Set[str]:
         return self._included
 
     @property
-    def excluded(self) -> List[str]:
+    def excluded(self) -> Set[str]:
         return self._excluded
 
     @property