From 168d4bbcbb8a0901cfe86320b9d659e354d052e3 Mon Sep 17 00:00:00 2001 From: Javier Julio Date: Tue, 5 Nov 2024 17:23:29 -0500 Subject: [PATCH 1/2] Remove unnecessary require "rake" This causes an error on bundle install when installing the gem from source. 16.66 [!] There was an error while loading `launchdarkly-server-sdk.gemspec`: cannot load such file -- rake. Bundler cannot continue. 16.66 16.66 # from /usr/local/bundle/ruby/3.3.0/bundler/gems/ruby-server-sdk-c7080edbad3a/launchdarkly-server-sdk.gemspec:6 16.66 # ------------------------------------------- 16.66 # require "ldclient-rb/version" 16.66 > require "rake" 16.66 # 16.66 # ------------------------------------------- --- launchdarkly-server-sdk.gemspec | 1 - 1 file changed, 1 deletion(-) diff --git a/launchdarkly-server-sdk.gemspec b/launchdarkly-server-sdk.gemspec index 4f63c8b2..00a5df3c 100644 --- a/launchdarkly-server-sdk.gemspec +++ b/launchdarkly-server-sdk.gemspec @@ -3,7 +3,6 @@ lib = File.expand_path("lib", __dir__) $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) require "ldclient-rb/version" -require "rake" # rubocop:disable Metrics/BlockLength Gem::Specification.new do |spec| From 86a31fcaa75f7fb0a132a16993de247157bce971 Mon Sep 17 00:00:00 2001 From: Javier Julio Date: Tue, 5 Nov 2024 17:26:17 -0500 Subject: [PATCH 2/2] Replace FileList with Dir to fix error This causes an error on bundle install when installing the gem from source. FileList comes from Rake but it's unnecessary as Dir is a very common use in popular gemspecs. [!] There was an error while loading `launchdarkly-server-sdk.gemspec`: uninitialized constant FileList. Bundler cannot continue. # from /Users/j.julio/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/bundler/gems/launchdarkly-ruby-server-sdk-b8220416fe3f/launchdarkly-server-sdk.gemspec:18 # ------------------------------------------- # > spec.files = FileList["lib/**/*", "README.md", "LICENSE.txt"] # spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } # ------------------------------------------- --- launchdarkly-server-sdk.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/launchdarkly-server-sdk.gemspec b/launchdarkly-server-sdk.gemspec index 00a5df3c..2a5dc609 100644 --- a/launchdarkly-server-sdk.gemspec +++ b/launchdarkly-server-sdk.gemspec @@ -15,7 +15,7 @@ Gem::Specification.new do |spec| spec.homepage = "https://github.com/launchdarkly/ruby-server-sdk" spec.license = "Apache-2.0" - spec.files = FileList["lib/**/*", "README.md", "LICENSE.txt"] + spec.files = Dir["lib/**/*.rb", "README.md", "LICENSE.txt"] spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } spec.require_paths = ["lib"] spec.required_ruby_version = ">= 3.0.0"