From 01c3b056e50f6302ff571be8ff69440055d15d3b Mon Sep 17 00:00:00 2001 From: Patrick Kaeding Date: Mon, 8 Feb 2016 17:45:28 -0800 Subject: [PATCH] send sdk default value with flag request events --- lib/ldclient-rb/ldclient.rb | 2 +- spec/ldclient_spec.rb | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/ldclient-rb/ldclient.rb b/lib/ldclient-rb/ldclient.rb index 9bb21697..a4c924a8 100644 --- a/lib/ldclient-rb/ldclient.rb +++ b/lib/ldclient-rb/ldclient.rb @@ -147,7 +147,7 @@ def toggle?(key, user, default = false) value = evaluate(feature, user) value = value.nil? ? default : value - add_event(kind: "feature", key: key, user: user, value: value) + add_event(kind: "feature", key: key, user: user, value: value, default: default) LDNewRelic.annotate_transaction(key, value) return value rescue StandardError => error diff --git a/spec/ldclient_spec.rb b/spec/ldclient_spec.rb index 7dd28b60..38c49689 100644 --- a/spec/ldclient_spec.rb +++ b/spec/ldclient_spec.rb @@ -76,6 +76,10 @@ result = client.toggle?(feature[:key], user, "default") expect(result).to eq "default" end + it "will specify the default value in the feature request event" do + expect(client).to receive(:add_event).with(hash_including(default: "default")) + result = client.toggle?(feature[:key], user, "default") + end it "requires user" do expect(client.instance_variable_get(:@config).logger).to receive(:error) result = client.toggle?(feature[:key], nil, "default")